1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270

package main

import (
	"os"
	"path/filepath"
	"strings"
	"testing"
)

// The environment database exists because per-app runtime.hosty files sat
// inside directories systemd chowns to the app's own DynamicUser, making an
// app the owner of its own secret store. These tests pin down the properties
// that move relies on: that constraints are actually enforced, that a secret
// cannot outlive its app, and that ports cannot be double-assigned.

// foreign_keys defaults to OFF in SQLite, and an unenforced foreign key is
// worse than none: it reads as a guarantee while silently accepting orphans.
// The DSN spelling is also easy to get subtly wrong — this driver ignores
// unknown DSN parameters silently, which is how an earlier _journal_mode=
// attempt set nothing at all (see the comment on openDB). So assert the pragma
// took effect rather than trusting the connection string.
func TestEnvDBEnforcesForeignKeys(t *testing.T) {
	db, err := openEnvDB(t.TempDir())
	if err != nil {
		t.Fatalf("openEnvDB: %v", err)
	}
	defer db.Close()

	var on int
	if err := db.QueryRow(`PRAGMA foreign_keys`).Scan(&on); err != nil {
		t.Fatalf("reading pragma: %v", err)
	}
	if on != 1 {
		t.Fatalf("foreign_keys = %d, want 1 (constraints would not be enforced)", on)
	}

	// The behavioural counterpart: a secret for an app that does not exist must
	// be refused, not quietly stored.
	if _, err := db.Exec(
		`INSERT INTO _hosty_secrets (app, key, value) VALUES ('ghost', 'K', 'v')`,
	); err == nil {
		t.Fatal("inserted a secret for a nonexistent app; foreign key not enforced")
	}
}

// A stopped-and-removed app must not leave its secrets behind. Previously they
// lived in the app directory, so removing the directory removed them; with a
// shared database that only holds if the app row is deleted and the cascade
// fires.
func TestAppForgetCascadesSecrets(t *testing.T) {
	db, err := openEnvDB(t.TempDir())
	if err != nil {
		t.Fatalf("openEnvDB: %v", err)
	}
	defer db.Close()

	if err := secretSet(db, "rss-parrot", "SECRET_KEY", "s3cr3t"); err != nil {
		t.Fatalf("secretSet: %v", err)
	}
	if err := appSetPort(db, "rss-parrot", "35343"); err != nil {
		t.Fatalf("appSetPort: %v", err)
	}
	if v, err := secretGet(db, "rss-parrot", "SECRET_KEY"); err != nil || v != "s3cr3t" {
		t.Fatalf("secretGet = %q, %v; want the stored value", v, err)
	}

	if err := appForget(db, "rss-parrot"); err != nil {
		t.Fatalf("appForget: %v", err)
	}

	if _, err := secretGet(db, "rss-parrot", "SECRET_KEY"); err == nil {
		t.Fatal("secret survived appForget; secrets would outlive the app")
	}
	// The port claim is released by the same delete, so the number is free for
	// another app.
	if err := appSetPort(db, "other-app", "35343"); err != nil {
		t.Fatalf("port was not released by appForget: %v", err)
	}
}

// Ports used to be recorded only in each app's own file, so nothing could tell
// whether another app already held one. freePort() asks the kernel, which
// answers "unused right now" — not "unclaimed by a stopped hosty app".
func TestPortIsUniqueAcrossApps(t *testing.T) {
	db, err := openEnvDB(t.TempDir())
	if err != nil {
		t.Fatalf("openEnvDB: %v", err)
	}
	defer db.Close()

	if err := appSetPort(db, "hosty-hello", "39333"); err != nil {
		t.Fatalf("appSetPort: %v", err)
	}

	err = appSetPort(db, "rss-parrot", "39333")
	if err == nil {
		t.Fatal("two apps were assigned the same port")
	}
	// The error must name the culprit: the failure surfaces at install time,
	// where "which app has it" is the only useful next question.
	if !strings.Contains(err.Error(), "hosty-hello") {
		t.Fatalf("error %q does not say which app holds the port", err)
	}

	// Re-assigning the same port to the *same* app is not a conflict; that is
	// the ordinary case of re-running `hosty start` on an installed app.
	if err := appSetPort(db, "hosty-hello", "39333"); err != nil {
		t.Fatalf("re-assigning an app its own port failed: %v", err)
	}
}

// appPort answers "no port yet" rather than failing, because callers use it to
// decide whether to allocate one.
func TestAppPortAbsentIsNotAnError(t *testing.T) {
	db, err := openEnvDB(t.TempDir())
	if err != nil {
		t.Fatalf("openEnvDB: %v", err)
	}
	defer db.Close()

	p, err := appPort(db, "never-installed")
	if err != nil {
		t.Fatalf("appPort on unknown app returned an error: %v", err)
	}
	if p != "" {
		t.Fatalf("appPort = %q, want empty", p)
	}

	// A registered app that has not been assigned a port yet is the same
	// answer: registration happens before allocation in setup().
	if err := appRegister(db, "registered"); err != nil {
		t.Fatalf("appRegister: %v", err)
	}
	if p, err := appPort(db, "registered"); err != nil || p != "" {
		t.Fatalf("appPort = %q, %v; want empty and no error", p, err)
	}
}

// The database holds every app's secrets, so anything reading them must scope
// by app. An unscoped read in `hosty export -include-secrets` would write other
// apps' secrets into one app's export file.
func TestSecretsAreScopedByApp(t *testing.T) {
	db, err := openEnvDB(t.TempDir())
	if err != nil {
		t.Fatalf("openEnvDB: %v", err)
	}
	defer db.Close()

	if err := secretSet(db, "app-a", "SHARED_KEY", "value-a"); err != nil {
		t.Fatalf("secretSet: %v", err)
	}
	if err := secretSet(db, "app-b", "SHARED_KEY", "value-b"); err != nil {
		t.Fatalf("secretSet: %v", err)
	}

	// Same key name, different apps, different values — they must not collide.
	if v, _ := secretGet(db, "app-a", "SHARED_KEY"); v != "value-a" {
		t.Fatalf("app-a sees %q, want value-a", v)
	}
	if v, _ := secretGet(db, "app-b", "SHARED_KEY"); v != "value-b" {
		t.Fatalf("app-b sees %q, want value-b", v)
	}

	all, err := secretsAll(db, "app-a")
	if err != nil {
		t.Fatalf("secretsAll: %v", err)
	}
	if len(all) != 1 || all["SHARED_KEY"] != "value-a" {
		t.Fatalf("secretsAll(app-a) = %v, want only app-a's own secret", all)
	}

	// Unsetting one app's secret must leave the other's alone.
	if err := secretUnset(db, "app-a", "SHARED_KEY"); err != nil {
		t.Fatalf("secretUnset: %v", err)
	}
	if v, _ := secretGet(db, "app-b", "SHARED_KEY"); v != "value-b" {
		t.Fatalf("unsetting app-a's secret disturbed app-b (got %q)", v)
	}
}

// The file holds every app's secrets in cleartext, so its mode is load-bearing:
// the whole point of the move is that it is not owned by, or readable by, any
// app.
func TestEnvDBIsNotWorldReadable(t *testing.T) {
	dir := t.TempDir()
	db, err := openEnvDB(dir)
	if err != nil {
		t.Fatalf("openEnvDB: %v", err)
	}
	defer db.Close()

	fi, err := os.Stat(filepath.Join(dir, envDBName))
	if err != nil {
		t.Fatalf("stat: %v", err)
	}
	if mode := fi.Mode().Perm(); mode != 0600 {
		t.Fatalf("%s mode = %04o, want 0600", envDBName, mode)
	}
}

// Opening must be idempotent: hosty opens this database on nearly every
// command, and re-running `hosty start` on an installed app must not disturb
// what is already recorded.
func TestOpenEnvDBIsIdempotent(t *testing.T) {
	dir := t.TempDir()

	db, err := openEnvDB(dir)
	if err != nil {
		t.Fatalf("first openEnvDB: %v", err)
	}
	if err := secretSet(db, "app", "K", "v"); err != nil {
		t.Fatalf("secretSet: %v", err)
	}
	if err := appSetPort(db, "app", "1234"); err != nil {
		t.Fatalf("appSetPort: %v", err)
	}
	db.Close()

	db2, err := openEnvDB(dir)
	if err != nil {
		t.Fatalf("second openEnvDB: %v", err)
	}
	defer db2.Close()

	if v, err := secretGet(db2, "app", "K"); err != nil || v != "v" {
		t.Fatalf("secret did not survive reopen: %q, %v", v, err)
	}
	if p, err := appPort(db2, "app"); err != nil || p != "1234" {
		t.Fatalf("port did not survive reopen: %q, %v", p, err)
	}
	if v, err := envGet(db2, "schema_version"); err != nil || v != "1" {
		t.Fatalf("schema_version = %q, %v; want 1", v, err)
	}
}

// Environment-wide settings are the thing that had no home before, and the
// reason baseDomain ended up being proposed as a config file and then as a flag
// nobody could be relied on to type.
func TestEnvSettingsRoundTrip(t *testing.T) {
	db, err := openEnvDB(t.TempDir())
	if err != nil {
		t.Fatalf("openEnvDB: %v", err)
	}
	defer db.Close()

	if _, err := envGet(db, "base_domain"); err == nil {
		t.Fatal("unset setting returned a value")
	}
	if err := envSet(db, "base_domain", "hosty-test.profpatsch.de"); err != nil {
		t.Fatalf("envSet: %v", err)
	}
	if v, err := envGet(db, "base_domain"); err != nil || v != "hosty-test.profpatsch.de" {
		t.Fatalf("envGet = %q, %v", v, err)
	}
	// Overwriting must replace, not accumulate.
	if err := envSet(db, "base_domain", "apps.example.com"); err != nil {
		t.Fatalf("envSet overwrite: %v", err)
	}
	if v, _ := envGet(db, "base_domain"); v != "apps.example.com" {
		t.Fatalf("envGet after overwrite = %q", v)
	}
}

// An app directory named `images` would collide with the extracted image trees
// that live alongside app directories in the same state dir.
func TestImagesIsReservedAsAppName(t *testing.T) {
	if err := validateAppName("images"); err == nil {
		t.Fatal("app name \"images\" was accepted; it collides with the image tree directory")
	}
}